Skip to content

Fix: Only auto register settings if the plugin the connector references is installed and active.#11564

Open
jorgefilipecosta wants to merge 6 commits intoWordPress:trunkfrom
jorgefilipecosta:codex/connectors-auto-registration-gate
Open

Fix: Only auto register settings if the plugin the connector references is installed and active.#11564
jorgefilipecosta wants to merge 6 commits intoWordPress:trunkfrom
jorgefilipecosta:codex/connectors-auto-registration-gate

Conversation

@jorgefilipecosta
Copy link
Copy Markdown
Member

@jorgefilipecosta jorgefilipecosta commented Apr 13, 2026

Summary

  • keep connector setting auto-registration unchanged for AI providers
  • only auto-register non-AI connector settings when plugin.is_active exists, is callable, and returns true
  • add focused PHPUnit coverage for the AI and non-AI registration paths
  • The current behavior is wrong if plugin A registers a connector for plugin B we were having a bug where its settings were registered and exposed in REST even if plugin B was not installed and activated. This fixes the issue.

Testing

  • Verify the connectors page works as before.
  • Verify the unit tests pass.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@jorgefilipecosta jorgefilipecosta force-pushed the codex/connectors-auto-registration-gate branch from 1ca586c to 03be585 Compare April 16, 2026 06:03
@jorgefilipecosta jorgefilipecosta changed the title Connectors: Gate non-AI setting auto-registration Fix: Only auto register settings if the plugin the connector references is installed and active. Apr 19, 2026
@jorgefilipecosta jorgefilipecosta marked this pull request as ready for review April 19, 2026 11:18
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jorgefilipecosta.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Trac Ticket Missing

This pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac.

To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant